976 redirect to calculator page after creation #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #980 +/- ##
========================================================
Coverage 86.74% 86.74%
========================================================
Files 68 68
Lines 1056 1056
========================================================
Hits 916 916
Misses 140 140 ☔ View full report in Codecov by Sentry. |
DanielVajnagi
changed the base branch from
feature/calculator-constructor
to
calculators-constructor
DanielVajnagi
requested review from
loqimean,
olexandervanzuriak,
NVMakarenko,
KseniaGovorun,
alexy78 and
ktpe
ktpe
approved these changes
Nov 26, 2024
loqimean
requested changes
Nov 26, 2024
spec/requests/calculators_spec.rb
Outdated
| @@ -67,7 +67,8 @@ | |||
| post account_calculators_path, params: { calculator: valid_attributes } | |||
| end.to change(Calculator, :count).by(1) | |||
|
|
|||
| expect(response).to redirect_to(account_calculators_path) | |||
| calculator = Calculator.last | |||
There was a problem hiding this comment.
Ну що це таке? Я вже не один раз казав, що ми НІКОЛИ не використовуємо змінні у тестах
loqimean
reviewed
Nov 26, 2024
spec/requests/calculators_spec.rb
Outdated
| @@ -67,7 +67,7 @@ | |||
| post account_calculators_path, params: { calculator: valid_attributes } | |||
| end.to change(Calculator, :count).by(1) | |||
|
|
|||
| expect(response).to redirect_to(account_calculators_path) | |||
| expect(response).to redirect_to(account_calculator_path(slug: Calculator.last)) | |||
There was a problem hiding this comment.
use let for last calculator
loqimean
approved these changes
Dec 1, 2024
…r-page-after-creation
loqimean
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
Second Level Review
Summary of issue
After creation, the program should transfer to the page of this calculator in the admin panel
Summary of change
Created show page for calculator on admin, added redirect
CHECK LIST